This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Fix internal error when saving fast tracepoint definitions


Hi Simon,

OK with nit below addressed.  (Sorry!)

On 11/16/2015 06:44 PM, Simon Marchi wrote:

> index 31a4097..659b0c7 100644
> --- a/gdb/testsuite/gdb.trace/save-trace.exp
> +++ b/gdb/testsuite/gdb.trace/save-trace.exp
> @@ -76,6 +76,8 @@ foreach x { 1 2 3 4 5 6 } {
>  	    "end" "^$"
>  }
>  
> +gdb_test "ftrace fast_tracepoint_loc" "Fast tracepoint $decimal at $hex: file .*$srcfile, line $decimal.*" "Set a fast tracepoint"
> +

Break overly long line.  Also, usually test messages are all lowercase ("set a fast ...").

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]