This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH c++ 12/12] xtensa: Add missing statics
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Tue, 03 Nov 2015 16:19:20 +0000
- Subject: Re: [PATCH c++ 12/12] xtensa: Add missing statics
- Authentication-results: sourceware.org; auth=none
- References: <1446560804-18858-1-git-send-email-simon dot marchi at ericsson dot com> <1446560804-18858-12-git-send-email-simon dot marchi at ericsson dot com>
On 11/03/2015 02:26 PM, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> This actually fixes the build in C:
>
> /home/simark/src/binutils-gdb/gdb/xtensa-linux-nat.c:100:1: error: no previous prototype for âsupply_gregset_regâ [-Werror=missing-prototypes]
> supply_gregset_reg (struct regcache *regcache,
> ^
> /home/simark/src/binutils-gdb/gdb/xtensa-linux-nat.c:257:1: error: no previous prototype for âxtensa_linux_fetch_inferior_registersâ [-Werror=missing-prototypes]
> xtensa_linux_fetch_inferior_registers (struct target_ops *ops,
> ^
> /home/simark/src/binutils-gdb/gdb/xtensa-linux-nat.c:272:1: error: no previous prototype for âxtensa_linux_store_inferior_registersâ [-Werror=missing-prototypes]
> xtensa_linux_store_inferior_registers (struct target_ops *ops,
> ^
> cc1: all warnings being treated as errors
>
> These functions are local to this file, so they should be static.
>
> gdb/ChangeLog:
>
> * xtensa-linux-nat.c (supply_gregset_reg): Make static.
> (xtensa_linux_fetch_inferior_registers): Likewise.
> (xtensa_linux_store_inferior_registers): Likewise.
OK.
Thanks,
Pedro Alves