This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH c++ 12/12] xtensa: Add missing statics


On 11/03/2015 02:26 PM, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> This actually fixes the build in C:
> 
> /home/simark/src/binutils-gdb/gdb/xtensa-linux-nat.c:100:1: error: no previous prototype for âsupply_gregset_regâ [-Werror=missing-prototypes]
>  supply_gregset_reg (struct regcache *regcache,
>  ^
> /home/simark/src/binutils-gdb/gdb/xtensa-linux-nat.c:257:1: error: no previous prototype for âxtensa_linux_fetch_inferior_registersâ [-Werror=missing-prototypes]
>  xtensa_linux_fetch_inferior_registers (struct target_ops *ops,
>  ^
> /home/simark/src/binutils-gdb/gdb/xtensa-linux-nat.c:272:1: error: no previous prototype for âxtensa_linux_store_inferior_registersâ [-Werror=missing-prototypes]
>  xtensa_linux_store_inferior_registers (struct target_ops *ops,
>  ^
> cc1: all warnings being treated as errors
> 
> These functions are local to this file, so they should be static.
> 
> gdb/ChangeLog:
> 
> 	* xtensa-linux-nat.c (supply_gregset_reg): Make static.
> 	(xtensa_linux_fetch_inferior_registers): Likewise.
> 	(xtensa_linux_store_inferior_registers): Likewise.

OK.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]