This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 4/4] btrace: add instruction-history /s and fix documentation


"Metzger, Markus T" <markus.t.metzger@intel.com> writes:
>> -----Original Message-----
>> From: Eli Zaretskii [mailto:eliz@gnu.org]
>> Sent: Monday, October 19, 2015 11:37 AM
>> To: Metzger, Markus T
>> Cc: dje@google.com; gdb-patches@sourceware.org; palves@redhat.com
>> Subject: Re: [PATCH v2 4/4] btrace: add instruction-history /s and fix
>> documentation
>
> Thanks for the quick response.
>
>> > +It can also print mixed source+disassembly by specifying the @code{/m}
>> > +or @code{/s} modifier and print the raw instructions in hex as well as
>> > +in symbolic form by specifying the @code{/r} modifier.
>> 
>> "By specifying" makes it sound like you are talking about the command,
>> because of the "It" that starts the sentence.  Suggest to reword:
>> 
>>   It can also print mixed source+disassembly if you specify the @code{/m}
>>   or @code{/s} modifier, and print the raw instructions in hex as well as
>>   in symbolic form by specifying the @code{/r} modifier.
>> 
>> Note that I also added a missing comma before "and".
>
> Fixed.  Thanks.

4/4 LGTM otherwise.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]