This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 4/4] btrace: add instruction-history /s and fix documentation
- From: Doug Evans <xdje42 at gmail dot com>
- To: "Metzger\, Markus T" <markus dot t dot metzger at intel dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>, "palves\ at redhat dot com" <palves at redhat dot com>
- Date: Sun, 25 Oct 2015 23:12:35 +0000
- Subject: Re: [PATCH v2 4/4] btrace: add instruction-history /s and fix documentation
- Authentication-results: sourceware.org; auth=none
- References: <1445246610-11645-1-git-send-email-markus dot t dot metzger at intel dot com> <1445246610-11645-5-git-send-email-markus dot t dot metzger at intel dot com> <83h9lngpwo dot fsf at gnu dot org> <A78C989F6D9628469189715575E55B2333205FFD at IRSMSX104 dot ger dot corp dot intel dot com>
"Metzger, Markus T" <markus.t.metzger@intel.com> writes:
>> -----Original Message-----
>> From: Eli Zaretskii [mailto:eliz@gnu.org]
>> Sent: Monday, October 19, 2015 11:37 AM
>> To: Metzger, Markus T
>> Cc: dje@google.com; gdb-patches@sourceware.org; palves@redhat.com
>> Subject: Re: [PATCH v2 4/4] btrace: add instruction-history /s and fix
>> documentation
>
> Thanks for the quick response.
>
>> > +It can also print mixed source+disassembly by specifying the @code{/m}
>> > +or @code{/s} modifier and print the raw instructions in hex as well as
>> > +in symbolic form by specifying the @code{/r} modifier.
>>
>> "By specifying" makes it sound like you are talking about the command,
>> because of the "It" that starts the sentence. Suggest to reword:
>>
>> It can also print mixed source+disassembly if you specify the @code{/m}
>> or @code{/s} modifier, and print the raw instructions in hex as well as
>> in symbolic form by specifying the @code{/r} modifier.
>>
>> Note that I also added a missing comma before "and".
>
> Fixed. Thanks.
4/4 LGTM otherwise.