This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix inconsistent breakpoint kinds between breakpoints and tracepoints in GDBServer.
- From: Pedro Alves <palves at redhat dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Thu, 22 Oct 2015 16:17:32 +0100
- Subject: Re: [PATCH] Fix inconsistent breakpoint kinds between breakpoints and tracepoints in GDBServer.
- Authentication-results: sourceware.org; auth=none
- References: <1445526373-6168-1-git-send-email-antoine dot tremblay at ericsson dot com>
On 10/22/2015 04:06 PM, Antoine Tremblay wrote:
> This patch fixes a regression introduced by :
> https://sourceware.org/ml/gdb-patches/2015-10/msg00369.html
>
> Tests : gdb.trace/trace-break.exp and gdb.trace/trace-mt.exp would fail on x86
> with gdbserver-{native,extended}.
>
> Before this patch, the breakpoint kind set by GDB with a Z packet and the one
> set in the case of a tracepoint would be inconsistent on targets that did not
> implement breakpoint_kind_from_pc. On x86 for example a breakpoint set by GDB
> would have a kind of 1 but a breakpoint set by a tracepoint would have a kind of
> 0.
Bummer. :-/ But, wouldn't it work to make the default be instead:
int
default_breakpoint_kind_from_pc (CORE_ADDR *pcptr)
{
int size;
target_sw_breakpoint_from_kind (0, &size);
return size;
}
?
Thanks,
Pedro Alves