This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] (patch 2/4, v2) [nto] Implement procfs_pid_to_exec_file.
- From: Pedro Alves <palves at redhat dot com>
- To: Aleksandar Ristovski <aristovski at qnx dot com>, gdb-patches at sourceware dot org
- Date: Tue, 20 Oct 2015 16:24:02 +0100
- Subject: Re: [PATCH 3/3] (patch 2/4, v2) [nto] Implement procfs_pid_to_exec_file.
- Authentication-results: sourceware.org; auth=none
- References: <56263FED dot 3050602 at redhat dot com> <1445351294-18179-1-git-send-email-aristovski at qnx dot com> <1445351294-18179-4-git-send-email-aristovski at qnx dot com>
On 10/20/2015 03:28 PM, Aleksandar Ristovski wrote:
> gdb/ChangeLog:
>
> * gdb/nto-procfs.c (procfs_pid_to_exec_file): New function.
> (init_procfs_targets): Wire new function.
> ---
> gdb/nto-procfs.c | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/gdb/nto-procfs.c b/gdb/nto-procfs.c
> index ac54c32..e7882ba 100644
> --- a/gdb/nto-procfs.c
> +++ b/gdb/nto-procfs.c
> @@ -617,6 +617,33 @@ procfs_files_info (struct target_ops *ignore)
> (nodestr != NULL) ? nodestr : "local node");
> }
>
> +/* Read executable file name for the given PID. */
> +
Please write instead:
/* Target to_pid_to_exec_file implementation. */
> +static char *
> +procfs_pid_to_exec_file (struct target_ops *ops, const int pid)
> +{
OK with that change.
Thanks,
Pedro Alves