This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 10/16/2015 03:23 PM, Antoine Tremblay wrote:
On 10/16/2015 03:04 PM, Pedro Alves wrote:Note that there's always a need to implement _one_ hook on all architecture. In your version, it's the breakpoint_from_pc hook. In my suggestion, it's breakpoint_from_kind. But it's the same number of "hooks x architectures implementations".Good point it would only transfer the operation to archs that can software single step basically, I withdraw this concern.
Humm thinking more about it however if we were to apply the same logic to pc and pcfull.
Removing the pc from the struct would cause a call to breakpoint_kind_from_pc to be mandatory.
Would you see too pc to be removed ? And replaced by a call to : static CORE_ADDR bp_pc (CORE_ADDR *pcptr) { return breakpoint_kind_from_pc (pcptr, 0) }
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |