Re: [PATCH v2 3/7] Implement breakpoint_from_kind for supported architectures in GDBServer.

[Antoine Tremblay <antoine dot tremblay at ericsson dot com>]

On 10/15/2015 06:57 AM, Antoine Tremblay wrote:
> On 10/15/2015 05:19 AM, Yao Qi wrote:
> > Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
> >
> > There is no changelog entry.
> Wow sorry adding it.
>
> > > +/* Implementation of linux_target_ops method
> > > "breakpoint_from_kind".  */
> > > +
> > > +static const unsigned char *
> > > +aarch64_breakpoint_from_kind (int *kind)
> > > +{
> > > +    return (const unsigned char *) &aarch64_breakpoint;
> >
> > Indentation looks odd, and do we really need the cast?
>
> Fixed.

Note this was changed to gdb_byte the cast is removed and 
aarch64_breakpoint is returned not &aarch64_breakpoint...

> > Note that this function is correct because we restrict the usage of Z0
> > packet.  Z0 packet is only used with non-extended protocol and inferior
> > is 64bit.  See aarch64_supports_z_point_type.  Once we remove the
> > restriction, we need to update this function to return different
> > breakpoint instructions (aarch64, arm, thumb, and thumb2) according to
> > *KIND and other information.
>
> Yes indeed.
>
> > Otherwise, patch is OK to me.