This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] py-type.exp: Do not run tests if binary fails to build


On 09/28/2015 05:44 AM, Simon Marchi wrote:
> I noticed this while working on the test case.  I believe it would make
> sense to skip running the tests if the binary failed to build.  Although
> I would understand the opposite argument: if the binary does not build
> for some reason, we probably want to know about it, and some catastrophic
> failures in the tests might alarm us better than a timid "UNTESTED".
> 

We already do this everywhere else we use prepare_for_testing, etc., though.

So ...

> gdb/testsuite/ChangeLog:
> 
> 	* gdb.python/py-type.exp: Do not run tests if binaries fail to
> 	build.

Looks fine to me with the missing newline:

> +  }
> +}
> \ No newline at end of file
> 

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]