This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v12 08/32] Permit multiple sysroot directories
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 22 Aug 2015 10:31:17 +0300
- Subject: Re: [PATCH v12 08/32] Permit multiple sysroot directories
- Authentication-results: sourceware.org; auth=none
- References: <20150821212006 dot 6673 dot 35100 dot stgit at host1 dot jankratochvil dot net> <20150821212111 dot 6673 dot 85003 dot stgit at host1 dot jankratochvil dot net>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Date: Fri, 21 Aug 2015 23:21:11 +0200
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -35,6 +35,9 @@ show debug bfd-cache
> The "/m" option is now considered deprecated: its "source-centric"
> output hasn't proved useful in practice.
>
> +* The "set sysroot" (and "show sysroot") commands now permit multiple
> + directory paths.
A "path" is already a list, so I suggest this variant instead:
The "set sysroot" (and "show sysroot") commands now accept PATH-style
lists of directories.
> -Use @var{path} as the system root for the program being debugged. Any
> +Use @var{path} as the system root (or list of system roots) for the
> +program being debugged. Any
"or a list of system root directories" is more clear, I think.
> -If @var{path} starts with the sequence @file{target:} and the target
> +Multiple entries may be delimited by the host platform path separator in use.
Suggest a rewording:
"Multiple sysroot directories can be specified in @var{path},
separated by the host platform's path separator character (colon
@samp{:} on Unix, semi-colon @samp{;} on MS-Windows, etc.)."
> +If @var{path} starts with the sequence @file{target:} (even if the host
> +platform path separator is character @file{:}) and the target
^^^^^^^^^^^^^^^^^^
The "character" part is redundant, and please use @samp instead of
@file.
> -Display the current executable and shared library prefix.
> +Display the current executable and shared library prefix(es).
I think "prefix" is wrong here. Why not simplify like this:
Display the current value of sysroot, which is used to look for
executable and shared libraries.
?
Thanks.