This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 1/2] D: Support looking up symbols in the current and imported modules
- From: Doug Evans <xdje42 at gmail dot com>
- To: Iain Buclaw <ibuclaw at gdcproject dot org>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Pierre-Marie de Rodat <derodat at adacore dot com>
- Date: Wed, 12 Aug 2015 21:01:47 -0700
- Subject: Re: [PATCH v3 1/2] D: Support looking up symbols in the current and imported modules
- Authentication-results: sourceware.org; auth=none
- References: <CABOHX+diCq3hB1g66c7hhoCgfJ9A67EiSBd-E99edrWHskWKbQ at mail dot gmail dot com>
Iain Buclaw <ibuclaw@gdcproject.org> writes:
> Third times a charm.
>
> Rebased this against master, in particular to make it compatible with
> the recent block_symbol additions. I don't have a GCC-4.1 compiler at
> hand, but I don't think I'm doing anything that may trigger build
> warnings. Pierre, maybe you want to confirm?
>
> I've also gotten round to completing the d-exp expression parser
> rewrite - or at least to a nice stable point. Will be submitting that
> in patch #2.
>
> Regards
> Iain
>
> ---
>
> ---
> 2015-08-03 Iain Buclaw <ibuclaw@gdcproject.org>
>
> * Makefile.in (SFILES): Add d-namespace.c.
> (COMMON_OBS): Add d-namespace.o.
> * d-lang.c (d_language_defn): Use d_lookup_symbol_nonlocal as the
> la_lookup_symbol_nonlocal callback function pointer.
> * d-lang.h (d_lookup_symbol_nonlocal): New declaration.
> (d_lookup_nested_symbol): New declaration.
> * d-namespace.c: New file.
Hi.
LGTM (with the one nit fixed that Pierre-Marie pointed out).