This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Initialize `location' in gdbpy_decode_line
- From: Doug Evans <dje at google dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 12 Aug 2015 10:45:17 -0700
- Subject: Re: [PATCH] Initialize `location' in gdbpy_decode_line
- Authentication-results: sourceware.org; auth=none
- References: <1439401110-12694-1-git-send-email-keiths at redhat dot com>
On Wed, Aug 12, 2015 at 10:38 AM, Keith Seitz <keiths@redhat.com> wrote:
> BuildBot flagged an uninitialized variable coming from one of the patches
> in my recently committed locations/explicit patchset.
>
> The following patch fixes this.
>
> Ok?
>
> gdb/ChangeLog
>
> * python/python.c (gdbpy_decode_line): Initialize `location' to NULL
> and only call decode_line_1 when it is non-NULL.
>
> diff --git a/gdb/python/python.c b/gdb/python/python.c
> index c28f98b..14da62c 100644
> --- a/gdb/python/python.c
> +++ b/gdb/python/python.c
> @@ -730,7 +730,7 @@ gdbpy_decode_line (PyObject *self, PyObject *args)
> PyObject *result = NULL;
> PyObject *return_result = NULL;
> PyObject *unparsed = NULL;
> - struct event_location *location;
> + struct event_location *location = NULL;
>
> if (! PyArg_ParseTuple (args, "|s", &arg))
> return NULL;
> @@ -747,7 +747,7 @@ gdbpy_decode_line (PyObject *self, PyObject *args)
>
> TRY
> {
> - if (arg)
> + if (location != NULL)
> sals = decode_line_1 (location, 0, 0, 0);
> else
> {
LGTM