This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/5] Introduce get_value_arch
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Tue, 28 Jul 2015 11:06:22 -0400
- Subject: Re: [PATCH 3/5] Introduce get_value_arch
- Authentication-results: sourceware.org; auth=none
- References: <1437072684-26565-1-git-send-email-simon dot marchi at ericsson dot com> <1437072684-26565-3-git-send-email-simon dot marchi at ericsson dot com> <55B22112 dot 5000703 at redhat dot com> <55B6A6FA dot 4010104 at ericsson dot com> <55B758AF dot 7050205 at redhat dot com>
On 15-07-28 06:25 AM, Pedro Alves wrote:
> FWIW, to my non-native ears, "associated with" sounds more
> natural. I'd write:
>
> /* Return the gdbarch associated with the value's type. */
> )
>
> Thanks,
> Pedro Alves
Pushed version:
>From e512cdbdffafefa63baeb835ba6636fcef56e17d Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Tue, 28 Jul 2015 11:01:50 -0400
Subject: [PATCH] Introduce get_value_arch
Similar to get_type_arch, used to get the gdbarch associated to a
struct value.
gdb/ChangeLog:
* value.c (get_value_arch): New function.
* value.h (get_value_arch): New declaration.
---
gdb/ChangeLog | 5 +++++
gdb/value.c | 8 ++++++++
gdb/value.h | 4 ++++
3 files changed, 17 insertions(+)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1e83384..93e054b 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2015-07-28 Simon Marchi <simon.marchi@ericsson.com>
+ * value.c (get_value_arch): New function.
+ * value.h (get_value_arch): New declaration.
+
+2015-07-28 Simon Marchi <simon.marchi@ericsson.com>
+
* value.c (struct value): Update comments.
2015-07-28 Simon Marchi <simon.marchi@ericsson.com>
diff --git a/gdb/value.c b/gdb/value.c
index 7fb7e2b..0d540d5 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -340,6 +340,14 @@ struct value
VEC(range_s) *optimized_out;
};
+/* See value.h. */
+
+struct gdbarch *
+get_value_arch (const struct value *value)
+{
+ return get_type_arch (value_type (value));
+}
+
int
value_bits_available (const struct value *value, int offset, int length)
{
diff --git a/gdb/value.h b/gdb/value.h
index 7ff6aa8..e25f52b 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -99,6 +99,10 @@ struct value *value_next (struct value *);
extern struct type *value_type (const struct value *);
+/* Return the gdbarch associated with the value. */
+
+extern struct gdbarch *get_value_arch (const struct value *value);
+
/* This is being used to change the type of an existing value, that
code should instead be creating a new value with the changed type
(but possibly shared content). */
--
2.1.4