This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/5] Introduce get_value_arch
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Tue, 28 Jul 2015 11:25:51 +0100
- Subject: Re: [PATCH 3/5] Introduce get_value_arch
- Authentication-results: sourceware.org; auth=none
- References: <1437072684-26565-1-git-send-email-simon dot marchi at ericsson dot com> <1437072684-26565-3-git-send-email-simon dot marchi at ericsson dot com> <55B22112 dot 5000703 at redhat dot com> <55B6A6FA dot 4010104 at ericsson dot com>
On 07/27/2015 10:47 PM, Simon Marchi wrote:
> On 15-07-24 07:27 AM, Pedro Alves wrote:
>>> diff --git a/gdb/value.c b/gdb/value.c
>>> index 6314036..af354de 100644
>>> --- a/gdb/value.c
>>> +++ b/gdb/value.c
>>> @@ -340,6 +340,12 @@ struct value
>>> VEC(range_s) *optimized_out;
>>> };
>>>
>>
>> Missing "/* See foo.h. */ breadcrumb.
>
> Done, updated version:
>
> From 89ef69ae7265ae62b7c0faeb502021262c9d0103 Mon Sep 17 00:00:00 2001
> From: Simon Marchi <simon.marchi@ericsson.com>
> Date: Fri, 3 Jul 2015 14:36:44 -0400
> Subject: [PATCH] Introduce get_value_arch
>
> Similar to get_type_arch, used to get the gdbarch associated to a
> struct value.
>
LGTM.
> > +/* Return the gdbarch associated to the value. */
(
FWIW, to my non-native ears, "associated with" sounds more
natural. I'd write:
/* Return the gdbarch associated with the value's type. */
)
Thanks,
Pedro Alves