This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: ping: [testsuite patch] for: [PATCH] [PR corefiles/17808] i386: Fix internal error when prstatus in core file is too big
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org, Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- Date: Thu, 16 Jul 2015 16:35:22 +0100
- Subject: Re: ping: [testsuite patch] for: [PATCH] [PR corefiles/17808] i386: Fix internal error when prstatus in core file is too big
- Authentication-results: sourceware.org; auth=none
- References: <20150205073758 dot GA25305 at host1 dot jankratochvil dot net> <54D33C45 dot 4010706 at redhat dot com> <20150214151231 dot GA29106 at host1 dot jankratochvil dot net> <54E33A8D dot 80504 at redhat dot com> <20150217165629 dot GA24936 at host1 dot jankratochvil dot net> <55A4CDD1 dot 6060907 at gmail dot com> <20150714180748 dot GA13461 at host1 dot jankratochvil dot net> <86fv4pjt4m dot fsf at gmail dot com> <20150715165849 dot GA12070 at host1 dot jankratochvil dot net> <867fq0jijf dot fsf at gmail dot com> <20150716143750 dot GA27870 at host1 dot jankratochvil dot net>
Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> Because this testcase comes from a different bug from 2009:
> https://bugzilla.redhat.com/show_bug.cgi?id=457187
> http://pkgs.fedoraproject.org/cgit/gdb.git/commit/?id=94cd124608bf0dd359cb48a710800d72c21b30c3
>
> That bug has been fixed in the meantime but the same testcase was reproducing
> this new different bug - internal error regression - so I submitted
> it.
I see, that is clear to me now.
>
> We can remove the "x/i $address" test but it was useful for the previous bug
> from 2009 as that time the internal error regression did not happen, just the
> core file was not recognized (which would not be detected by the proposed
> ignoring of the "core-file" command output) and so the core file was not
> available. That can be tested by the "x/i $address" test.
>
Yeah, I agree it is useful to keep this test there, but we need comments
on the purpose of such test, for example,
# Test bug https://bugzilla.redhat.com/show_bug.cgi?id=457187
gdb_test "x/i $address" "\r\n\[ \t\]*$address:\[ \t\]*hlt\[ \t\]*" ".text is readable"
>
> But we could be upstreaming much more Fedora testcases which I do not plan to.
> Fedora contains many testcases - 49
> grep '^#=' gdb.spec|sed 's/[:+].*//'|sort|uniq -c
> 49 #=fedoratest
> for various bugs already fixed upstream. But given there isn't enough work
> resources to upstream even Fedora fixes (hacks) I have never much attempted to
> upstream all the testcases there.
> http://pkgs.fedoraproject.org/cgit/gdb.git/tree/
> (Some/few of the testcases are also a different form of the upstreamed variant
> of the same testcase kept to be really sure no regressions are needlessly
> missed in Fedora/RHEL.)
I don't work on any distribution, so I don't know.
--
Yao (éå)