This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/3] convert tui window names to lower case


On Wed, Jul 8, 2015 at 4:51 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> On Wed, Jul 8, 2015 at 4:37 PM, Andrew Burgess
> <andrew.burgess@embecosm.com> wrote:
>> This patch series converts the tui window names to lower case.  The
>> window names are already lower case in the documentation, and the
>> recently added command completer for 'focus' reports window names as
>> lower case.
>>
>> The window names aren't actally shown in that many places, so this
>> change shouldn't be that big of a upset (I hope), plus all the
>> commands that take a window name already accepts both upper and lower
>> case.
>
> Cool, I thought about doing something like this too, after I added the
> "focus" completer.
>
> What about the occurrences of "SRC", "CMD", etc in tui-layout.c?
> These do not seem to be changed in this series but it seems like they
> should.

On second thought, never mind this concern.  The occurrences of "SRC",
"CMD", etc in tui-layout.c are referring to layout names, not window
names, so they should not necessarily be replaced by the window-name
macros.  Besides, it can always be done in a separate patch.  So FWIW
I am happy with this series :)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]