This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/8] [AArch64] Refactor aarch64_make_stub_cache
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pierre Langlois <pierre dot langlois at arm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 08 Jul 2015 17:10:25 +0100
- Subject: Re: [PATCH 2/8] [AArch64] Refactor aarch64_make_stub_cache
- Authentication-results: sourceware.org; auth=none
- References: <1436273518-5959-1-git-send-email-pierre dot langlois at arm dot com> <1436273518-5959-3-git-send-email-pierre dot langlois at arm dot com>
Pierre Langlois <pierre.langlois@arm.com> writes:
> static struct aarch64_prologue_cache *
> -aarch64_make_stub_cache (struct frame_info *this_frame)
> +aarch64_make_stub_cache (struct frame_info *this_frame, void **this_cache)
> {
We need comments on this function, about its arguments and return value.
> - int reg;
> struct aarch64_prologue_cache *cache;
> - CORE_ADDR unwound_fp;
> +
> + if (*this_cache)
if (*this_cache != NULL)
> + return *this_cache;
OK with these changes.
--
Yao (éå)