This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v8 09/10] Validate symbol file using build-id
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, Doug Evans <dje at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Aleksandar Ristovski <ARistovski at qnx dot com>
- Date: Wed, 08 Jul 2015 15:44:25 +0100
- Subject: Re: [PATCH v8 09/10] Validate symbol file using build-id
- Authentication-results: sourceware.org; auth=none
- References: <20150614192542 dot 18346 dot 87859 dot stgit at host1 dot jankratochvil dot net> <20150614192655 dot 18346 dot 17075 dot stgit at host1 dot jankratochvil dot net> <20150621101644 dot GA12733 at host1 dot jankratochvil dot net> <CADPb22TH5nfFSkCzW9cCiHuoJFAG+P5z=qZawgwGUgYQ5kfd5Q at mail dot gmail dot com> <20150623204702 dot GA2156 at host1 dot jankratochvil dot net>
Jan Kratochvil wrote:
> +static char *
> +svr4_validate (const struct so_list *const so)
> +{
...
> + return xstrprintf (_("remote build ID is %s "
> + "but local file does not have build ID"),
> + remote_hex);
Seems odd to say "remote" here. Can't these errors trigger with native
debugging as well?
Doug Evans wrote:
>
>> > If so, having solib in the option name is confusing.
>> >
>> > set build-id-force
>> > or
>> > set require-build-id-match
>> > or some such would be clearer.
"build-id-force" sound odd to me. The latter sounds OK,
as would "set build-id-validation on/off/...".
With that, and once the previous issues raised are
addressed, I think this is good to go.
Thanks,
Pedro Alves