This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 11/11] New target_ops hook to_can_do_single_step
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 02 Jul 2015 10:09:24 +0100
- Subject: Re: [PATCH 11/11] New target_ops hook to_can_do_single_step
- Authentication-results: sourceware.org; auth=none
- References: <1435759111-22856-1-git-send-email-yao dot qi at linaro dot org> <1435759111-22856-12-git-send-email-yao dot qi at linaro dot org> <55941892 dot 3000902 at redhat dot com> <866163os3x dot fsf at gmail dot com>
On 07/02/2015 09:56 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> But my issue with it is that this breaks gdb/gdbserver compatibility.
>>
>> Old GDB has:
>>
>> /* If s, S, c, and C are not all supported, we can't use vCont. Clearing
>> BUF will make packet_ok disable the packet. */
>> if (!support_s || !support_S || !support_c || !support_C)
>> buf[0] = 0;
>>
>> Which means that new x86-86 gdbserver with old gdb will just
>> stop using vCont after this change.
>
> I think you meant new arm gdbserver, which doesn't return s and S in the
> reply, old gdb will stop using vCont.
Yeah.
>
>>
>> And old arm gdbserver will still claim support for vCont;s packets,
>> which means that new gdb with old gdbserver will be broken.
>
> That is right. I'll do it in qSupported features.
Thanks.
--
Pedro Alves