This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Make sure to update registers if frame information has changed
- From: Patrick Palka <patrick at parcs dot ath dot cx>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: Patrick Palka <patrick at parcs dot ath dot cx>
- Date: Wed, 1 Jul 2015 08:42:24 -0400
- Subject: Re: [PATCH] Make sure to update registers if frame information has changed
- Authentication-results: sourceware.org; auth=none
- References: <1435754216-31399-1-git-send-email-patrick at parcs dot ath dot cx>
On Wed, Jul 1, 2015 at 8:36 AM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> When I removed TUI's frame_changed hook to fix PR tui/13378 I assumed
> that there's no reason to refresh register information following a call
> to "up", "down" or "frame". This assumption was made to fix the problem
> of refreshing frame information twice following a sync-execution normal
> stop (once in tui_normal_stop and then in tui_before_prompt) -- the
> second refresh removing any highlights made by the first.
>
> I was wrong about that -- GDB's snapshot of register information is
> per-frame, and when the frame changes, registers do too (most
> prominently the %rip and %rsp registers). So e.g. GDB 7.8 would
> highlight such register changes after invoking "up", "down" or "frame",
> and current GDB does not.
>
> To fix this regression, I added another (sufficient) condition for
To be more precise, s/I added/this patch adds/