This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/5] Update how find_separate_debug_file handles CANON_DIR argument
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Cc: Cédric Buissart <cedric dot buissart at gmail dot com>
- Date: Wed, 01 Jul 2015 12:13:20 +0100
- Subject: Re: [PATCH 3/5] Update how find_separate_debug_file handles CANON_DIR argument
- Authentication-results: sourceware.org; auth=none
- References: <1434447768-17328-1-git-send-email-gbenson at redhat dot com> <1434447768-17328-4-git-send-email-gbenson at redhat dot com>
On 06/16/2015 10:42 AM, Gary Benson wrote:
> find_separate_debug_file's CANON_DIR argument is used to create an
> alternate location to search for debug files. This commit moves
> that logic out of the loop it's in and introduces a new variable
> altdir to hold the generated alternate location. A check is added
> to inhibit the altdir search if alternate location is the same as
> the regular location specified in DIR. A check was also added for
> gdb_sysroot == NULL, which the original code was missing.
I think the "gdb_sysroot != NULL" check is no longer necessary, right?
Otherwise looks fine.
Thanks,
Pedro Alves