This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/5] Update how find_separate_debug_file handles CANON_DIR argument


On 06/16/2015 10:42 AM, Gary Benson wrote:
> find_separate_debug_file's CANON_DIR argument is used to create an
> alternate location to search for debug files.  This commit moves
> that logic out of the loop it's in and introduces a new variable
> altdir to hold the generated alternate location.  A check is added
> to inhibit the altdir search if alternate location is the same as
> the regular location specified in DIR.  A check was also added for
> gdb_sysroot == NULL, which the original code was missing.

I think the "gdb_sysroot != NULL" check is no longer necessary, right?

Otherwise looks fine.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]