This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch v2 3/5, nios2] fix register save offset for signal handler trampolines
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>, Yao Qi <qiyaoltc at gmail dot com>
- Date: Fri, 08 May 2015 10:30:55 +0100
- Subject: Re: [patch v2 3/5, nios2] fix register save offset for signal handler trampolines
- Authentication-results: sourceware.org; auth=none
- References: <554172F8 dot 2020108 at codesourcery dot com> <55417801 dot 5070507 at codesourcery dot com>
Sandra Loosemore <sandra@codesourcery.com> writes:
> It was requested that I split the patch previously posted here:
>
> https://sourceware.org/ml/gdb-patches/2015-04/msg00907.html
>
> into two parts. This is the first part. I also expanded the comments
> to indicate how the register save offset magic number was calculated.
Hi Sandra,
The reason I suggest to describe how this magic number is calculated in
this mail https://sourceware.org/ml/gdb-patches/2015-04/msg01038.html is
to make the code more maintainable. Supposing some one changes the
offset in linux kernel in the future, we'll quickly know how to update
the magic number. However, I don't insist on this...
>
> OK to commit now?
Yes, it is OK.
--
Yao (éå)