Re: [PATCH v5] Add Guile frame filter interface

[Eli Zaretskii <eliz at gnu dot org>]

> From: Andy Wingo <wingo@igalia.com>
> Cc: dje@google.com
> Date: Thu, 09 Apr 2015 18:27:42 +0200
> 
> > Changes from v4 are mostly related to feedback on the unwinder
> > interface (which is a different patch).
> >
> >   * Remove enable-frame-filter! / disable-frame-filter!, and just have
> >     set-frame-filter-enabled!, which always takes a filter object and
> >     never a string.
> >
> >   * Rename #:scope to #:locus.  Names must be unique only within a
> >     locus, not among all filters.  Add #:replace? to
> >     register-frame-filter!.
> >
> >   * Limit priorities to the signed int32 range.
> >
> >   * Rename unregister-frame-filter! to remove-frame-filter!.
> >
> >   * Update docs.
> >
> >   * Compile most .scm files with -Wunbound-variable, and not
> >     -Wunbound-toplevel.
> >
> > WDYT?
> 
> Voici le patch, mesdames et messieurs:

Thanks.

> +not.  @code{scope} is the objfile or progspace in which the filter was

This sentence will begin with a lower-case letter.  Suggest to use
"The @code{scope} field" instead.

> +An decorated frame is a Guile record type that holds information about
   ^^
"A"

> +frame @var{dec}.  Each item of the list should either be a
> +@value{GDBN} symbol (@pxref{Symbols In Guile}), a pair of a
> +@value{GDBN} symbol and a @value{GDBN} value (@pxref{Values From
> +Inferior In Guile}, or a pair of a string and a @value{GDBN} value.
> +In the first case, the value will be loaded from the frame if needed.

I'm confused: the first case is when the item is a symbol, so what
value is being alluded to here?

> +@example

Please use @smallexample everywhere.

> +                         To ensure that your Guile filters can run,
> +you might need to disable any Python frame filters loaded in your
> +session.

It would be useful here to tell how, or to add a cross-reference to a
node which holds such a description.

Thanks.