This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/7] Implement remote_pid_to_exec_file using qXfer:exec-file:read
- From: Gary Benson <gbenson at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: Doug Evans <xdje42 at gmail dot com>, gdb-patches at sourceware dot org
- Date: Tue, 7 Apr 2015 10:08:40 +0100
- Subject: Re: [PATCH 5/7] Implement remote_pid_to_exec_file using qXfer:exec-file:read
- Authentication-results: sourceware.org; auth=none
- References: <1427887341-31819-1-git-send-email-gbenson at redhat dot com> <1427887341-31819-6-git-send-email-gbenson at redhat dot com> <834mozsxtq dot fsf at gnu dot org> <m3pp7hi44n dot fsf at sspiff dot org> <83fv8djhp0 dot fsf at gnu dot org>
Eli Zaretskii wrote:
> > From: Doug Evans <xdje42@gmail.com>
> > Cc: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
> > Date: Mon, 06 Apr 2015 10:00:08 -0700
> >
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > > > Date: Wed, 1 Apr 2015 12:22:19 +0100
> > > >
> > > > +qXfer:exec-file:read
> > > > + Return the pathname of the file that was executed to create a
> > > ^^^^^^^^^^^^^^^^^^^^^^^^
> > > "the name of the file"
> > >
> > > OK with this change.
> > >
> > > > +@item qXfer:exec-file:read:@var{annex}:@var{offset},@var{length}
> > > > +@anchor{qXfer executable filename read}
> > > > +Return the pathname of the file that was executed to create a process
> > > ^^^^^^^^^^^^^^^^^^^^^^^^
> > > Likewise.
> > >
> > > Otherwise, the documentation parts are OK.
> >
> > "the name of the file" is ambiguous though.
> > Is it the full path name of the file? Or the base name?
>
> I don't know the answers, but if this is a "full path name", then
> "the full absolute name of the file" will convey that.
It should be absolute. I will use "the full absolute name of the
file" as Eli suggests.
Thanks,
Gary
--
http://gbenson.net/