This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin

On 03/25/2015 05:51 PM, Jon TURNEY wrote:
> On 23/03/2015 14:39, Jon TURNEY wrote:
>> On 20/03/2015 17:23, Pedro Alves wrote:
>>> On 03/20/2015 04:06 PM, Jon TURNEY wrote:
>>>> On 18/03/2015 23:34, Pedro Alves wrote:
>>>>> On 03/06/2015 01:01 PM, Jon TURNEY wrote:
>>>>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_"
>>>>>> for
>>>>>> x86_64-*-cygwin
>>>> [...]
>>>>>> 2015-03-04  Jon TURNEY  <>
>>>>>>     * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
>>>>>>     SYMBOL_PREFIX for x86_64-*-cygwin.
>>>>> OK.
>>>> I do not have write access, so can you apply this, please.
>>> Are you planning on working on GDB further?  (That'd be
>>> awesome, btw.)  We can get you write access so you can
>>> push your own patches.  Let me know if you'd like that.
>> Yes, please.
> So it seems I do have write access, although I didn't know this :-)


> Can I go ahead and commit this?


Please add yourself to write-after-approval section of
the gdb/MAINTAINERS file.  No need for approval for that
one.  Just post the patch/commit to the list for the archives.

Pedro Alves

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]