RE: [PATCH] btrace: fix tests for 32-bit

["Metzger, Markus T" <markus dot t dot metzger at intel dot com>]

> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Wednesday, March 25, 2015 12:23 PM
> To: Metzger, Markus T
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH] btrace: fix tests for 32-bit

Thanks for your review!


> > Split it into x86_64-record_goto.S and i686-record_goto.S.  Luckily, we
> > can use either one with the same test .exp file.
> >
> > It further turned out that most tests do not really need a fixed binary;
> > they should work pretty well with a newly-compiled C program.  The
> > one thing that breaks this is the heavy use of "record goto" to navigate
> > inside the recorded execution.
> 
> OOC, why do we need .S files for "record goto"?  Can we have a
> comment somewhere mentioning that?

I added this comment to record_goto.exp:

# The "record goto" command jumps to a specific instruction in the execution
# trace.  To guarantee that we always get the same execution trace, we use
# an assembly source file.
#

, this comment to stepi.exp:

# This test is stepping on instruction level.  To guarantee that we always
# get the same execution trace, we use an assembly source file.
#

, and this comment to tailcall.exp:

# This test requires the compiler to generate a tail call.  To guarantee that
# we always get one, we use an assembly source file.
#
# We use different assembly sources based on the target architecture.
#
# Luckily, they are similar enough that a single test script can handle
# both.

The instruction_history.exp test uses a hand-written assembly source.
I did not add a comment to this.

> >  # start inferior
> > -standard_testfile x86-record_goto.S
> > -if [prepare_for_testing step.exp $testfile $srcfile] {
> > +if [prepare_for_testing finish.exp $testfile $srcfile] {
> 
> Typo here.                 ^^^^^^^^^^
> 
> Otherwise looks fine to me.

Thanks.  I fixed the typo and I'm going to push the two patches later today.

Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052