This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/4] GDBServer: add 'monitor set server-stderr' command
- From: Cleber Rosa <crosa at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org, areis at redhat dot com
- Date: Mon, 23 Mar 2015 17:09:13 -0300
- Subject: Re: [PATCH 4/4] GDBServer: add 'monitor set server-stderr' command
- Authentication-results: sourceware.org; auth=none
- References: <1426905265-8495-1-git-send-email-crosa at redhat dot com> <1426905265-8495-5-git-send-email-crosa at redhat dot com> <831tkivjmh dot fsf at gnu dot org>
On 03/21/2015 05:29 AM, Eli Zaretskii wrote:
From: Cleber Rosa <crosa@redhat.com>
Cc: crosa@redhat.com, areis@redhat.com
Date: Fri, 20 Mar 2015 23:34:25 -0300
gdb/doc/Changelog:
2015-03-20 Cleber Rosa <crosa@redhat.com>
* gdb.texinfo (info): Add documentation about the 'monitor set
server-stderr' command
Don't forget the period at the end of the sentence.
+@item monitor set server-stderr [PATH]
You want "[@var{path}]" instead. And please don't call this "path",
for the reasons I explained in my other message.
Sure! BTW, I mistakenly added [PATH] as an optional parameter, and it
should be mandatory. Because of that, this is the new version:
@item monitor set server-output @var{output_filename}
Redirect the server output to a file given by @var{output_filename}.
Also, FIY, the server behavior when the "output_filename" parameter is
not passed in, is currently the same as when a parameter is missing from
another commands such as "monitor set remote-debug":
(gdb) monitor set server-output
Unknown monitor command.
...
Protocol error with Rcmd
(gdb) monitor set remote-debug
Unknown monitor command.
...
Protocol error with Rcmd
It looks like this is an area that can receive some improvement, but
it's obviously outside the scope of the changes proposed/worked here.
+Redirect the server stderr to a file given by @var{path}.
Same comments as in my other message: instead of referencing "stderr",
reference the server's output.
Thanks.
Sure! I should really have learned that lesson by now!
Thanks a million!