This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v4 03/13] sim/erc32: Switched emulated memory to host endian order.



On 23/03/15 03:45, Mike Frysinger wrote:
> On 17 Mar 2015 22:02, Jiri Gaisler wrote:
>> --- a/sim/erc32/erc32.c
>> +++ b/sim/erc32/erc32.c
>> +#ifdef HOST_LITTLE_ENDIAN
>> +	    waddr ^= 3;
>> +#endif
>> +	    mem[waddr] = *data & 0x0ff;
> 
> doesn't this assume the target is big endian ?  this shows up a few times in 
> the changes to this file.
> 

The target (SPARC) is always big endian, so I believe this is correct.

I will fix the rest of your comments and resend.

Jiri.

Attachment: signature.asc
Description: OpenPGP digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]