This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Reimplement "vFile:fstat" without qSupported
- From: Gary Benson <gbenson at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Date: Wed, 18 Mar 2015 11:25:14 +0000
- Subject: Re: [PATCH] Reimplement "vFile:fstat" without qSupported
- Authentication-results: sourceware.org; auth=none
- References: <1426590248-20310-1-git-send-email-gbenson at redhat dot com> <5509449D dot 2040705 at redhat dot com>
Pedro Alves wrote:
> On 03/17/2015 11:04 AM, Gary Benson wrote:
> > When I implemented the vFile:fstat packet the other week I didn't
> > understand how support for the other vFile packets was negotiated.
> > I implemented it using qSupported to indicate support, which means
> > the vFile:fstat packet is handled differently from all other vFile
> > packets--and for no good reason.
> >
> > This commit makes support for the vFile:fstat packet be determined
> > by probing rather than using qSupported. This makes it consistent
> > with all other vFile packets.
> >
> > Built and regtested on RHEL 6.6 x86_64.
> >
> > Ok to commit?
>
> OK.
Thanks Eli, Pedro, this is pushed now.
Cheers,
Gary
--
http://gbenson.net/