This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Support gzip compressed exec and core files in gdb


On 03/11/15 09:15, Eli Zaretskii wrote:
Date: Tue, 10 Mar 2015 16:01:42 -0700
From: Michael Eager <eager@eagerm.com>

GDB/DOC:
    * gdb.texinfo: Mention gzipped exec and core files.

This should mention the name of the node where you make changes; see
the other ChangeLog entries in gdb/doc/.

Do we need a NEWS entry for this?

--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -17391,6 +17391,11 @@ via @code{gdbserver} (@pxref{Server, file, Using the @code{gdbserver}
  Program}).  In these situations the @value{GDBN} commands to specify
  new files are useful.

+Executable and core files may be compressed using @code{gzip}.  These

'gzip' is a command, so please use @command, not @code.

+files will be uncompressed into temporary files either in /tmp

'/tmp' is a file name, so please use @file for its markup.

                                                                 or in
+@code{$TMPDIR} if this is set in the environment.

I'd prefer to say

   in the system-wide temporary directory

and mention neither /tmp nor $TMPDIR, as both are platform-dependent.

I think it might be good to tell people how to specify where the
uncompressed file is located.


Otherwise, the documentation parts are OK.

Thanks.  I'll make the changes.

I agree with Mike that it's better to use library functions for
creating temporary files, since that hides platform dependencies.

The code uses mkstemp() to create a temporary file.  Is there a
GDB or BFD wrapper for this function?


--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]