This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH 2/2] Create gdb/break-catch-syscall.c
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 11 Mar 2015 14:15:47 -0400
- Subject: Re: [PATCH 2/2] Create gdb/break-catch-syscall.c
- Authentication-results: sourceware.org; auth=none
- References: <1426030105-15485-1-git-send-email-sergiodj at redhat dot com> <1426030105-15485-3-git-send-email-sergiodj at redhat dot com> <86ioe7hirx dot fsf at gmail dot com>
On Wednesday, March 11 2015, Yao Qi wrote:
> Sergio Durigan Junior <firstname.lastname@example.org> writes:
> Hi Sergio,
> Thanks for doing this.
I felt compelled after your patch :-).
>> Tested by running the 'gdb.base/catch-syscall.exp' testcase.
> Could you please run the whole testsuite? it shouldn't take much time.
> If it is regression free, the patch is fine by me, with the following
> typo fixed,
Sure thing. I rand the testsuite and the results are fine.
>> 2015-03-10 Sergio Durigan Junior <email@example.com>
>> * Makefile.in (SFILES): New object break-catch-syscall.o.
> It should be break-catch-syscall.c
Ops, thanks for catching this! Fixed.
>> (COMMON_OBS): Likewise.
>> * break-catch-syscall.c: New file.
>> * breakpoint.c: Remove inclusion of "xml-syscall.h".
>> (syscall_catchpoint_p): Move declaration to break-catch-syscall.c
>> (struct syscall_catchpoint): Likewise.
>> (dtor_catch_syscall): Likewise.
>> (catch_syscall_inferior_data): Likewise.
>> (struct catch_syscall_inferior_data): Likewise.
>> (get_catch_syscall_inferior_data): Likewise.
>> (catch_syscall_inferior_data_cleanup): Likewise.
>> (insert_catch_syscall): Likewise.
>> (remove_catch_syscall): Likewise.
>> (breakpoint_hit_catch_syscall): Likewise.
>> (print_it_catch_syscall): Likewise.
>> (print_one_catch_syscall): Likewise.
>> (print_mention_catch_syscall): Likewise.
>> (print_recreate_catch_syscall): Likewise.
>> (catch_syscall_breakpoint_ops): Likewise.
>> (syscall_catchpoint_p): Likewise.
>> (create_syscall_event_catchpoint): Likewise.
>> (catch_syscall_split_args): Likewise.
>> (catch_syscall_command_1): Likewise.
>> (is_syscall_catchpoint_enabled): Likewise.
>> (catch_syscall_enabled): Likewise.
>> (catching_syscall_number): Likewise.
>> (catch_syscall_completer): Likewise.
>> (clear_syscall_counts): Likewise.
>> (initialize_breakpoint_ops): Move initialization of syscall
>> catchpoints to break-catch-syscall.c.
>> (_initialize_breakpoint): Move code related to syscall catchpoints
>> to break-catch-syscall.c.
>> gdb/Makefile.in | 2 +
>> gdb/break-catch-syscall.c | 659 ++++++++++++++++++++++++++++++++++++++++++++++
>> gdb/breakpoint.c | 600 -----------------------------------------
>> 3 files changed, 661 insertions(+), 600 deletions(-)
>> create mode 100644 gdb/break-catch-syscall.c
>> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
>> index 8c2a4de..f59ad66 100644
>> --- a/gdb/Makefile.in
>> +++ b/gdb/Makefile.in
>> @@ -816,6 +816,7 @@ SFILES = ada-exp.y ada-lang.c ada-typeprint.c ada-valprint.c ada-tasks.c \
>> bfd-target.c \
>> block.c blockframe.c \
>> breakpoint.c break-catch-sig.c break-catch-throw.c \
>> + break-catch-syscall.o \
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible