This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH 2/6] Introduce throw_ptrace_error
- From: Pedro Alves <palves at redhat dot com>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 06 Mar 2015 21:40:03 +0000
- Subject: Re: [PATCH 2/6] Introduce throw_ptrace_error
- Authentication-results: sourceware.org; auth=none
- References: <1425671886-7798-1-git-send-email-palves at redhat dot com> <1425671886-7798-3-git-send-email-palves at redhat dot com> <201503062103 dot t26L3tef004332 at glazunov dot sibelius dot xs4all dot nl>
On 03/06/2015 09:03 PM, Mark Kettenis wrote:
>> From: Pedro Alves <firstname.lastname@example.org>
>> Date: Fri, 6 Mar 2015 19:58:02 +0000
>> This adds a new function that is meant to be called instead of
>> perror_with_name whenever we get an error out of ptrace. The
>> idea is to convert some errno errors to different GDB exceptions in
>> a following patch.
> What is ptrace-specific about throwing an error? This really feels
> like the wrong direction to me.
Not exactly sure what you mean. Throwing an error is
of course not ptrace-specific. What is ptrace-specific is the
interpretation of errno. The end result of the series is that
an ESRCH as a result of a ptrace error ends up throwing
a THREAD_NOT_FOUND_ERROR error instead of a GENERIC_ERROR. Then
callers up the chain can actually distinguish the errors.
Please take a look at patch 3. It should make things clearer.