This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] New common function "startswith"
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 3 Mar 2015 08:06:39 -0800
- Subject: Re: [PATCH] New common function "startswith"
- Authentication-results: sourceware.org; auth=none
- References: <1425388224-8146-1-git-send-email-gbenson at redhat dot com>
> This patch introduces a new common function "startswith" which takes
> two string arguments and returns nonzero if the first string starts
> with the second. It also updates the 180 places where this logic was
> written out longhand to use the new function.
> I almost pushed this as obvious, but I hesitated because of its size.
> Ok to commit?
> * common/common-utils.h (startswith): New declaration.
> * common/common-utils.c (startswith): New Function.
> All places where this logic was used updated to use the above.
Given the obvious errors in remote.c that you just fixed, I'd say
this is going to be a very useful function.
> diff --git a/gdb/common/common-utils.c b/gdb/common/common-utils.c
> index 2925dd5..5fb4af1 100644
> --- a/gdb/common/common-utils.c
> +++ b/gdb/common/common-utils.c
> @@ -151,3 +151,11 @@ savestring (const char *ptr, size_t len)
> p[len] = 0;
> return p;
> +/* See common-utils.h. */
> +startswith (const char *s1, const char *s2)
> + return startswith (s1, s2);
As pointed out by Andreas... ;-)
Also, how about we rename the parameters to something like "str"
instead of "s1" and "pattern" for s2. It makes it faster, IMO,
to figure out the parameter order without having to read the
function's documentation, and therefore makes it's use a little
I only skimmed through the patch, but it otherwise looks good to me.