This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [pushed] Add "../lib/unbuffer_output.c" and use it in gdb.base/interrupt.c (Re: [PATCH 5/6] testsuite: Introduce $inferior_spawn_id)
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Pedro Alves <palves at redhat dot com>
- Cc: qiyaoltc at gmail dot com, gdb-patches at sourceware dot org
- Date: Fri, 27 Feb 2015 16:43:06 +0200
- Subject: Re: [pushed] Add "../lib/unbuffer_output.c" and use it in gdb.base/interrupt.c (Re: [PATCH 5/6] testsuite: Introduce $inferior_spawn_id)
- Authentication-results: sourceware.org; auth=none
- References: <1424699660-11727-1-git-send-email-palves at redhat dot com> <1424699660-11727-6-git-send-email-palves at redhat dot com> <867fv7xodw dot fsf at gmail dot com> <54F04A2B dot 5 at redhat dot com> <54F04E16 dot 2070704 at redhat dot com> <54F05F2C dot 5020007 at gmail dot com> <54F07829 dot 9030009 at redhat dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Fri, 27 Feb 2015 13:59:05 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: gdb-patches@sourceware.org
>
> >> + Windows pipe, thus not a tty and its outputs ends up fully
> >> + buffered. */
> >> +#ifndef __MINGW32__
> >> + if (!isatty (fileno (stdin)))
> >> +#endif
> >
> > Include unistd.h for isatty?
> >
>
> ... with these fixed.
>
> Do you want to comment on the rest of the series, or shall I push it?
If that's isatty from the MS runtime, it will return non-zero for
every character device, including the null device. Is that what we
want here?