This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Build failure with probe patch
- From: Steve Ellcey <sellcey at imgtec dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: "Jose E. Marchesi" <jose dot marchesi at oracle dot com>, Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Thu, 19 Feb 2015 13:59:42 -0800
- Subject: Re: Build failure with probe patch
- Authentication-results: sourceware.org; auth=none
- References: <bac100bc-73de-4bf6-86b5-912ad6887c5a at BAMAIL02 dot ba dot imgtec dot org> <87wq3ercw0 dot fsf at redhat dot com> <1424306916 dot 27855 dot 115 dot camel at ubuntu-sellcey> <87r3tl7uwz dot fsf at oracle dot com> <54E6150B dot 9060808 at redhat dot com> <87vbix3iqm dot fsf at oracle dot com> <1424368119 dot 27855 dot 123 dot camel at ubuntu-sellcey> <87egply6gs dot fsf at oracle dot com> <87h9uhk4go dot fsf at redhat dot com> <1424382499 dot 27855 dot 130 dot camel at ubuntu-sellcey> <87bnkpin70 dot fsf at redhat dot com>
- Reply-to: <sellcey at imgtec dot com>
On Thu, 2015-02-19 at 16:52 -0500, Sergio Durigan Junior wrote:
> > 2015-02-19 Steve Ellcey <sellcey@imgtec.com>
> >
> > * dtrace-probe.c (dtrace_process_dof_probe): Initialize arg.expr.
> > (dtrace_get_probes) Change dof type.
>
> I prefer "Change type of variable 'dof'".
Ok.
> > - dtrace_process_dof (sect, objfile, probesp, dof);
> > + dtrace_process_dof (sect, objfile, probesp, (struct dtrace_dof_hdr *) dof);
>
> This line is too long. Break it after "probesp,".
OK, I will break that line up (should have seen that myself).
Steve Ellcey
sellcey@imgtec