This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 09/23] sim/erc32: removed type mismatch compiler warnings

From: Mike Frysinger <vapier at gentoo dot org>
To: Jiri Gaisler <jiri at gaisler dot se>
Cc: gdb-patches at sourceware dot org
Date: Tue, 17 Feb 2015 04:10:36 -0500
Subject: Re: [PATCH 09/23] sim/erc32: removed type mismatch compiler warnings
Authentication-results: sourceware.org; auth=none
References: <1424159099-5148-1-git-send-email-jiri at gaisler dot se> <1424159099-5148-10-git-send-email-jiri at gaisler dot se>

On 17 Feb 2015 08:44, Jiri Gaisler wrote:
> --- a/sim/erc32/func.c
> +++ b/sim/erc32/func.c
>
> -	fgets(lbuf, 1023, fp);
> +	tmp = fgets(lbuf, 1023, fp);

not a new issue, but fgets needs to die in a fire.  getline is a trivial API and 
does a lot of nice stuff for you :).
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH 09/23] sim/erc32: removed type mismatch compiler warnings
  - From: Jiri Gaisler

References:
- [PATCH 00/22] Update of the SPARC SIS simulator
  - From: Jiri Gaisler
- [PATCH 09/23] sim/erc32: removed type mismatch compiler warnings
  - From: Jiri Gaisler

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]