This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][PR symtab/17855] Fix.
- From: Doug Evans <xdje42 at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Pedro Alves <palves at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 28 Jan 2015 23:28:31 -0800
- Subject: Re: [PATCH][PR symtab/17855] Fix.
- Authentication-results: sourceware.org; auth=none
- References: <m33876ary6 dot fsf at sspiff dot org> <54C0E1FF dot 4050201 at redhat dot com> <m3egqe83x3 dot fsf at sspiff dot org> <20150129071929 dot GE5193 at adacore dot com>
On Wed, Jan 28, 2015 at 11:19 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> Aargh - I was working on it just now because I wasn't sure if anyone
> felt they "had the ball on their court".
>
>> Like so?
>>
>> 2015-01-28 Doug Evans <xdje42@gmail.com>
>>
>> PR symtab/17855
>> * symfile.c (clear_symtab_users): Move call to breakpoint_re_set
>> closer to end.
>
> What I've tested is moving the call last, as shown in the attached
> diff. Not technically necessarily better, but as the comment explains,
> I move it last so that it's after we've purged all relevant caches.
> That way, the function is organized in two rough sections:
> - do purges first;
> - do updates next.
> Your comment is a lot more detailed, I like it.
I think yours is fine too.
I'm ok with using it.