This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 03/13] btrace, linux: add perf event buffer abstraction
- From: Pedro Alves <palves at redhat dot com>
- To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 27 Jan 2015 15:49:32 +0000
- Subject: Re: [PATCH v2 03/13] btrace, linux: add perf event buffer abstraction
- Authentication-results: sourceware.org; auth=none
- References: <1416480444-9943-1-git-send-email-markus dot t dot metzger at intel dot com> <1416480444-9943-4-git-send-email-markus dot t dot metzger at intel dot com> <54C773CE dot 8040708 at redhat dot com> <A78C989F6D9628469189715575E55B231E6C7F80 at IRSMSX104 dot ger dot corp dot intel dot com>
On 01/27/2015 03:31 PM, Metzger, Markus T wrote:
>> Isn't there a better type to use here instead of "long long"?
>> Why not size_t, if a host buffer size; uint64_t, if it's a fixed
>> buffer format, assuming 64-bit here; or ULONGEST, the widest
>> integer we support?
>
> I'm using the same data type as the respective fields in
> struct perf_event_mmap_page (after resolving a few typedefs).
>
> I'm also fine to directly use __u64 or to use uint64_t.
Ah, so fits in "fixed format" category. Let's go with
uint64_t then.
Thanks,
Pedro Alves