This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA PATCH 2/3 V3] Add "class" option for pascal compiler
- From: Pedro Alves <palves at redhat dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>, "'Doug Evans'" <dje at google dot com>
- Cc: "'gdb-patches'" <gdb-patches at sourceware dot org>
- Date: Fri, 23 Jan 2015 10:45:09 +0000
- Subject: Re: [RFA PATCH 2/3 V3] Add "class" option for pascal compiler
- Authentication-results: sourceware.org; auth=none
- References: <54ae4586 dot 01e3440a dot 7b06 dot fffff844SMTPIN_ADDED_BROKEN at mx dot google dot com> <54AE605A dot 8050308 at redhat dot com> <54ae7f9f dot c323460a dot 36ed dot ffffff30SMTPIN_ADDED_BROKEN at mx dot google dot com> <54AE8914 dot 4010507 at redhat dot com> <54ae911b dot 85e3440a dot 1d96 dot 5ffdSMTPIN_ADDED_BROKEN at mx dot google dot com> <54AFB2E5 dot 5080307 at redhat dot com> <54afff61 dot 6790420a dot 0fa7 dot 4f63SMTPIN_ADDED_BROKEN at mx dot google dot com> <CADPb22TZH+Ab6xLi_pKspY1xeh76Ms7G5r2r_KcMEHn2pWd2tw at mail dot gmail dot com> <54b07891 dot 01b3c20a dot 2a7b dot ffff9f96SMTPIN_ADDED_BROKEN at mx dot google dot com> <CADPb22TC0Ftf59jM388FSdF7L8jz-Oav3PYYrq5N8KYVU8Z_uQ at mail dot gmail dot com> <54b6858f dot a287440a dot 5b61 dot ffff9ef0SMTPIN_ADDED_BROKEN at mx dot google dot com> <54C0F1E5 dot 3000207 at redhat dot com> <002901d036a1$5c2e30f0$148a92d0$ at muller@ics-cnrs.unistra.fr>
On 01/23/2015 12:13 AM, Pierre Muller wrote:
>> Pedro Alves wrote:
>>> + if { $i == "class" } {
>>> + if [board_info $dest exists pascal_class_flags] {
>>> + append add_flags " [board_info $dest pscal_class_flags]"
>>
>> It'd be good to try setting this in a board file to make sure it
>> works. I've spotted a typo here (same in the gpc branch):
>> "pscal_class_flags".
>
> I corrected the error below,
> but I never worked with boardinfo files,
> so I am not really sure how this works.
Should be something around this:
Create an empty ~/etc/site.exp file. Point the
DEJAGNU environment variable to it, like:
export DEJAGNU=/home/pedro/etc/site.exp
Create a ~/etc/boards/ directory, and create
a ~/etc/boards/fpc.exp file with this:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
unset_board_info isremote
set_board_info isremote 0
load_generic_config "unix"
set_board_info compiler "[find_gcc]"
set_board_info pascal_class_flags "-Mobjfpc"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Run the pascal tests with
make check RUNTESTFLAGS="--target_board=fpc --directory=gdb.pascal"
Play with $pascal_class_flags, and make sure it does have the
effect intended.
The patch looks good to me.
Thanks,
Pedro Alves