This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [testsuite patch] for: [PATCH] [PR corefiles/17808] i386: Fix internal error when prstatus in core file is too big
- From: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 09 Jan 2015 10:47:14 +0100
- Subject: Re: [testsuite patch] for: [PATCH] [PR corefiles/17808] i386: Fix internal error when prstatus in core file is too big
- Authentication-results: sourceware.org; auth=none
- References: <874ms18cyz dot fsf at br87z6lw dot de dot ibm dot com> <20150108164327 dot GA29029 at host2 dot jankratochvil dot net>
On Thu, Jan 08 2015, Jan Kratochvil wrote:
> On Thu, 08 Jan 2015 17:16:20 +0100, Andreas Arnez wrote:
>> Note that this behavior deviates from the default policy: In general, if
>> some future kernel adds new registers to a register set, then a GDB
>> unaware of this extension would read the known subset and just ignore
>> the unknown bytes.
>
> This patch is about 'assert' vs. 'if' so I find this paragraph outside of the
> topic of this thread/regression.
Right, it seems a bit off-topic. What I really mean is that "this
behavior *still* deviates from the default policy", and I just wanted to
make sure that we all agree to that. Anyway, I will remove this
paragraph from the commit message.
Any other comments? After adjusting the commit message, is the patch
then OK to apply?