This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH, ARM] Support for value 3 of Tag_ABI_VFP_args ARM attribute
- From: "Thomas Preud'homme" <thomas dot preudhomme at arm dot com>
- To: "'Joel Brobecker'" <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 29 Dec 2014 10:14:12 -0000
- Subject: RE: [PATCH, ARM] Support for value 3 of Tag_ABI_VFP_args ARM attribute
- Authentication-results: sourceware.org; auth=none
- References: <000101d02201$e9b4b430$bd1e1c90$ at arm dot com> <20141228034726 dot GA2123 at adacore dot com>
> From: Joel Brobecker [mailto:brobecker@adacore.com]
> Sent: Sunday, December 28, 2014 3:47 AM
>
> No problem.
>
> You forgot to provide the ChangeLog entry. FTR, here it is:
>
> 2014-12-25 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * arm-tdep.c (arm_gdbarch_init): Explicitly handle value 3 of
> Tag_ABI_VFP_args. Also replace hardcoded values by enum values in
> the
> switch handling the different values of Tag_ABI_VFP_args.
Thanks.
>
> Also, I don't think the cast to (int) are necessary, are they?
Sigh. Indeed, they aren't. My apologize. I remember adding them after seeing an error but I cannot reproduce it. So either I compiled with g++ (why would I?) or the error came from something else in the patch which I changed as well. Should I post a patch to fix this or can I commit it as obvious?
Best regards,
Thomas