This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v8] Events when inferior is modified
- From: Nick Bull <nicholaspbull at gmail dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>
- Date: Thu, 04 Dec 2014 10:45:46 +0000
- Subject: Re: [PATCH v8] Events when inferior is modified
- Authentication-results: sourceware.org; auth=none
- References: <5419C597 dot 4000300 at gmail dot com> <542C3F4D dot 70104 at redhat dot com> <5441432B dot 5040103 at gmail dot com> <21569 dot 29405 dot 219428 dot 940000 at ruffy dot mtv dot corp dot google dot com> <21569 dot 30068 dot 738159 dot 240720 at ruffy dot mtv dot corp dot google dot com> <5447A5A1 dot 7040708 at gmail dot com> <546A3AD5 dot 7020508 at gmail dot com> <CADPb22QmjPyaHR8E4s5y+s0P3QVDWEDKR9Dqr6OkbP1EumuubQ at mail dot gmail dot com> <546B75B9 dot 1050407 at gmail dot com> <CADPb22Rxjp6puNCz8a+s3sh84OG3fmB6J-ST6uAc9fWCuOvMdw at mail dot gmail dot com> <546DC41F dot 8020209 at gmail dot com> <21630 dot 4311 dot 741887 dot 195958 at ruffy2 dot mtv dot corp dot google dot com>
On 02/12/14 19:19, Doug Evans wrote:
> Nick Bull writes:
> >
> >
> > On 20/11/14 00:21, Doug Evans wrote:
> > > On Tue, Nov 18, 2014 at 8:37 AM, Nick Bull <nicholaspbull@gmail.com> wrote:
> > >> On 17/11/14 21:24, Doug Evans wrote:
> > >>> Hi.
> > >>>
> > >>> Let's go with ptids.
> > >>
> > >> Doug,
> > >>
> > >> Thanks. So is this version of the patch now good to apply? Note that I don't have
> > >> push access so will need someone to commit it on my behalf.
> > >
> > > Hi.
> > >
> > > I gave the patch one last look-over.
> > > It's almost good to apply but what remains is whitespace and a file name change.
> > >
> > > I wouldn't expect to find the register/memory change events in py-infcallevent.c
> > > so how about naming the file py-infevents.c?
> > >
> > > I'll make those changes and commit.
> > > [Saves you a round trip.]
> >
> > Excellent. Thanks to you and everyone else for your help.
>
> Here is what I committed.
>
> I tweaked a few things:
>
> - updated copyright year in one file
> - hardcoded line number in py-events.exp
> - ChangeLog
> - inferior_fn_handle -> inferior_call_handler
> - whitespace
> - py-infcallevent.c -> py-infevents.c
Many thanks Doug.
Nick