This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [arm] Fix fails in dw2-compdir-oldgcc.exp
- From: Yao Qi <yao at codesourcery dot com>
- To: <gdb-patches at sourceware dot org>
- Date: Sat, 22 Nov 2014 21:22:48 +0800
- Subject: Re: [PATCH] [arm] Fix fails in dw2-compdir-oldgcc.exp
- Authentication-results: sourceware.org; auth=none
- References: <1416230425-19468-1-git-send-email-yao at codesourcery dot com>
Yao Qi <yao@codesourcery.com> writes:
> This patch fixes two fails in dw2-compdir-oldgcc.exp I've seen on arm
> target thumb mode.
>
> FAIL: gdb.dwarf2/dw2-compdir-oldgcc.exp: info source gcc42
> FAIL: gdb.dwarf2/dw2-compdir-oldgcc.exp: info source gcc43
>
> When fill in DW_AT_low_pc, the label should be used rather than the
> function, otherwise, the LSB bit of the address in DW_AT_low_pc is
> set and the debug info is wrong. This patch is to add two labels for
> functions gcc42 and gcc43 respectively, and use them. These two
> fails are fixed.
>
> gdb/testsuite:
>
> 2014-11-17 Yao Qi <yao@codesourcery.com>
>
> * gdb.dwarf2/dw2-compdir-oldgcc.S: Define label .Lgcc42_procstart
> and .Lgcc43_procstart. Use .Lgcc42_procstart instead of gcc42.
> Use .Lgcc43_procstart instead of gcc43.
I've pushed it in.
--
Yao (éå)