This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 14/14] the "compile" command
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 21 Nov 2014 21:47:01 +0200
- Subject: Re: [PATCH v3 14/14] the "compile" command
- Authentication-results: sourceware.org; auth=none
- References: <20141101214552 dot 13230 dot 45564 dot stgit at host1 dot jankratochvil dot net> <20141101214733 dot 13230 dot 49968 dot stgit at host1 dot jankratochvil dot net> <8361exy4if dot fsf at gnu dot org> <20141120212406 dot GA23190 at host2 dot jankratochvil dot net> <8361e956jd dot fsf at gnu dot org> <20141121184132 dot GA8400 at host2 dot jankratochvil dot net>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Fri, 21 Nov 2014 19:41:32 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: gdb-patches@sourceware.org
>
> > Then maybe we need to tell what "persistent" means in this context.
> > Something like "visible to the rest of the program for the duration of
> > this run".
>
> I find this was said by "and only exist as long as the injected object code
> exists.". But I have therefore changed the sentence to:
> Variables and types that are created as part of the @code{compile}
> command are not visible to the rest of the program for the duration of
> this run.
>
> BTW I would say s/this run/its run/.
That's also fine.
> > OK, then let's say so explicitly. Something like
> >
> > Types defined in the @code{compile} will no longer be available in
> > the next @code{compile} command.
>
> I used it as you wrote. Although I would write:
> Types defined in the @code{compile} command will no longer be
> available in the next @code{compile} command.
That'd be fine as well.
I think the patch can go in now. Thanks.