This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Fix C++ virtual method pointer resolution
- From: Patrick Palka <patrick at parcs dot ath dot cx>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 21 Nov 2014 08:43:55 -0500
- Subject: Re: [PATCH 1/2] Fix C++ virtual method pointer resolution
- Authentication-results: sourceware.org; auth=none
- References: <1411355243-10812-1-git-send-email-patrick at parcs dot ath dot cx> <87k32og51t dot fsf at codesourcery dot com> <CA+C-WL8r=1mW=P0PxioLgfhS8pJsXkQb7Sm7iD3q4i-i3Cyhvg at mail dot gmail dot com> <87389cfze2 dot fsf at codesourcery dot com>
On Fri, Nov 21, 2014 at 8:37 AM, Yao Qi <yao@codesourcery.com> wrote:
> Patrick Palka <patrick@parcs.ath.cx> writes:
>
>>>> +get_debug_format
>>>> +
>>>> +if ![test_debug_format "DWARF 2"] {
>>>> + return 0
>>>> +}
>>>
>>> Why do we need to check test_debug_format here?
>>
>> Because GDB only supports C++ method pointers with the DWARF debug
>> format. So I'd assume that this test would fail for non-DWARF.
>
> I am not aware of this, any details? If GDB doesn't support C++ method
> pointers with non-DWARF, we should kfail or xfail it in the test. See
> gdb.cp/m-static.exp.
Err, sorry, I conflated the ABI (gnu-v3) with the debug format
(DWARF). That hunk is unnecessary.