This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/6] Fix implptr-optimized-out.exp fail
- From: Doug Evans <dje at google dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 4 Nov 2014 14:53:43 -0800
- Subject: Re: [PATCH 5/6] Fix implptr-optimized-out.exp fail
- Authentication-results: sourceware.org; auth=none
- References: <1414195968-3333-1-git-send-email-yao at codesourcery dot com> <1414195968-3333-6-git-send-email-yao at codesourcery dot com>
Yao Qi writes:
> Hi,
> I see the fail in gdb.dwarf2/implptr-optimized-out.exp in thumb mode
>
> (gdb) p p->f^M
> No symbol "p" in current context.^M
> (gdb) FAIL: gdb.dwarf2/implptr-optimized-out.exp: p p->f
>
> and the crash on powerpc64
>
> (gdb) continue^M
> Continuing.^M
> ^M
> Program received signal SIGSEGV, Segmentation fault.^M
> 0x7d82100810000828 in ?? ()
>
> The cause of both is that we incorrectly set attribute low_pc, since
> main isn't resolved to function start address on these targets.
>
> In this patch, we replace attributes name, low_pc and high_pc with
> MACRO_AT_func. The fail on thumb mode is fixed, and crash on
> powerpc64 is fixed too.
>
> gdb/testsuite:
>
> 2014-10-24 Yao Qi <yao@codesourcery.com>
>
> * gdb.dwarf2/implptr-optimized-out.exp (Dwarf::assemble):
> Replace name, low_pc and high_pc with MACRO_AT_func.
LGTM