This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [testsuite patch] runaway attach processes [Re: Regression: GDB stopped on run with attached process (PR 17347)]
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Doug Evans <dje at google dot com>, Mark Wielaard <mjw at redhat dot com>, gdb-patches at sourceware dot org
- Date: Fri, 12 Sep 2014 11:14:18 +0100
- Subject: Re: [testsuite patch] runaway attach processes [Re: Regression: GDB stopped on run with attached process (PR 17347)]
- Authentication-results: sourceware.org; auth=none
- References: <21434 dot 52532 dot 737427 dot 778289 at ruffy dot mtv dot corp dot google dot com> <53BC0D0B dot 7040001 at redhat dot com> <21437 dot 28600 dot 751354 dot 629884 at ruffy dot mtv dot corp dot google dot com> <53BD7749 dot 5000800 at redhat dot com> <20140903075858 dot GA23492 at host2 dot jankratochvil dot net> <540775D7 dot 7040003 at redhat dot com> <20140907192818 dot GA17035 at host2 dot jankratochvil dot net> <540DD8CF dot 5050200 at redhat dot com> <20140909182518 dot GA3320 at host2 dot jankratochvil dot net> <54119729 dot 5050206 at redhat dot com> <20140912073402 dot GA4134 at host2 dot jankratochvil dot net>
On 09/12/2014 08:34 AM, Jan Kratochvil wrote:
> On Thu, 11 Sep 2014 14:35:53 +0200, Pedro Alves wrote:
>> > Thanks, pushed to both master and 7.8.
> I have started seeing occasional runaway 'attach' processes these days.
> I cannot be certain it is really caused by this patch, for example
> grep 'FAIL.*cmdline attach run' does not show anything in my logs.
>
> But as I remember this 'attach' runaway process always happened in GDB (but
> I do not remember it in the past months) I think it would be most safe to just
> solve it forever by [attached].
Agreed. OK.
> gdb/testsuite/
> 2014-09-12 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.base/attach.c: Include unistd.h.
> (main): Call alarm. Add label postloop.
> * gdb.base/attach.exp (do_attach_tests): Use gdb_get_line_number,
> gdb_breakpoint, gdb_continue_to_breakpoint.
> (test_command_line_attach_run): Kill ${testpid} in one exit path.
Thanks,
Pedro Alves