This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [PR tdep/17379] Fix internal-error when stack pointer is invalid


Sergio Durigan Junior wrote:
> On Thursday, September 11 2014, Edjunior Barbosa Machado wrote:
> 
> > Thanks Sergio for your feedback. I'm resending the patch with an additional
> > testcase as you suggested.
> 
> Nice, thanks :-).
> 
> > diff --git a/gdb/testsuite/gdb.arch/powerpc-stackless.exp b/gdb/testsuite/gdb.arch/powerpc-stackless.exp
> > new file mode 100644
> > index 0000000..f4b2a90
> [...]
> > +standard_testfile powerpc-stackless.S
> 
> Just another really minor nit, no need to resubmit the patch because of
> this.  You can write:
> 
>   standard_testfile .S
> 
> Other than that, it is perfect.
> 
> Thanks a lot!

Thanks for the testcase (and the review)!

Edjunior, the patch is OK to check in with the change Sergio suggested.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]