This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [PR tdep/17379] Fix internal-error when stack pointer is invalid
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Edjunior Barbosa Machado <emachado at linux dot vnet dot ibm dot com>
- Cc: gdb-patches at sourceware dot org, Ulrich Weigand <uweigand at de dot ibm dot com>
- Date: Thu, 11 Sep 2014 19:20:44 -0400
- Subject: Re: [PATCH] [PR tdep/17379] Fix internal-error when stack pointer is invalid
- Authentication-results: sourceware.org; auth=none
- References: <1410476585-18046-1-git-send-email-emachado at linux dot vnet dot ibm dot com>
On Thursday, September 11 2014, Edjunior Barbosa Machado wrote:
> The problem is that rs6000_frame_cache attempts to read the stack backchain via
> read_memory_unsigned_integer, which throws an exception if the stack pointer is
> invalid. With this path, it calls safe_read_memory_integer instead, which
> doesn't throw an exception and allows for safe handling of that situation.
> Regression tested on ppc64{,le}. Ok?
Heya!
Thanks for the patch. Not having reviewed the code deeply to understand
if it's the best approach, I would just like to point that a testcase
for this would be awesome. As it turns out, you actually already have a
testcase almost written in the bug description :-).
Again, thanks for addressing those issues!
Cheers,
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/