This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 9/9 v7] Remove one GDBSERVER use from linux-waitpid.c
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Cc: Doug Evans <dje at google dot com>
- Date: Wed, 10 Sep 2014 14:29:31 +0100
- Subject: Re: [PATCH 9/9 v7] Remove one GDBSERVER use from linux-waitpid.c
- Authentication-results: sourceware.org; auth=none
- References: <1409320299-6812-1-git-send-email-gbenson at redhat dot com> <1409320299-6812-10-git-send-email-gbenson at redhat dot com>
On 08/29/2014 02:51 PM, Gary Benson wrote:
>
> -static unsigned int debug_linux_nat;
> +unsigned int debug_linux_nat;
> +
> +#define debug_linux_waitpid debug_linux_nat
> #endif
> +extern int debug_linux_waitpid;
>
The dangers of extern... This ends up undefined code, as
the variable is defined as signed, and then declared here
as signed.
Sorry, but now that I see it, IMO the end up resulting code
doesn't really look better than what we already have. :-/ We
end up with #ifdef GDBSERVER anyway, so might be best to
either leave this be until we come up with a complete solution.
Thanks,
Pedro Alves