This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Fix xmethod Python so that it works with Python 3
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Siva Chandra <sivachandra at google dot com>
- Cc: Doug Evans <dje at google dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Mon, 1 Sep 2014 08:30:47 +0200
- Subject: Re: [PATCH v2] Fix xmethod Python so that it works with Python 3
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gwQF17FXajAbgyQFhWSS2ymwRxMdPNY3y-AJZmfcwc4qg at mail dot gmail dot com> <21485 dot 14738 dot 947462 dot 758709 at ruffy dot mtv dot corp dot google dot com> <CAGyQ6gwhHznkNj33gxk-du+VL=wRp1KUP-k1xZPTkndbnQAbjg at mail dot gmail dot com> <CAGyQ6gzAZDjU=Rc4ifxV8X-54-MrGn-0ANL+TupqmEx=CzpZtw at mail dot gmail dot com>
> >> > ChangeLog:
> >> > 2014-08-14 Siva Chandra Reddy <sivachandra@gmail.com>
> >> >
> >> > gdb/
> >> >
> >> > * python/lib/gdb/command/xmethods.py (set_xm_status1): Use the
> >> > 'items' methods instead of 'iteritems' method on dictionaries.
> >> >
> >> > gdb/testsuite/
> >> >
> >> > * gdb.python/py-xmethods.py (A_getarrayind)
> >> > (E_method_char_worker.__call__, E_method_int_worker.__call__):
> >> > Use 'print' with function call syntax.
> >> > (E_method_matcher.match): Fix tab vs space indentation mixup.
> >>
> >> LGTM
> >
> > Pushed 940df408121be31beed22ef7a5ad133cb1592726.
>
> Missed asking: OK for 7.8 branch?
Yes. Pleasae make sure to update the branch's wiki as well
(section "Fixes in 7.8.1" - you might need to create a PR for that).
Thanks,
--
Joel